Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hazmapper PROD GA4 MeasurementID #158

Merged
merged 2 commits into from
Oct 13, 2023
Merged

Hazmapper PROD GA4 MeasurementID #158

merged 2 commits into from
Oct 13, 2023

Conversation

taoteg
Copy link
Contributor

@taoteg taoteg commented Oct 12, 2023

Overview:

Added new Google Analytics 4 tracking property MeasurementID for hazmapper in the base template page.

PR Status:

  • Ready.
  • Work in Progress.
  • Hold.

Related Jira tickets:

Summary of Changes:

  • Changed the GA4 code measurementID value.

Testing Steps:

  1. Build and run project.
  2. Verify new GA4 code is in all page templates.

UI Photos:

  • None

Notes:

  • None

nathanfranklin
nathanfranklin approved these changes Oct 13, 2023
View reviewed changes
Copy link
Collaborator

@nathanfranklin nathanfranklin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

can you run npm run prettier:fix and commit those formatting changes before merging.

sophia-massie
sophia-massie approved these changes Oct 13, 2023
View reviewed changes
Copy link
Contributor

@sophia-massie sophia-massie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@taoteg taoteg merged commit 93b1c0d into master Oct 13, 2023
5 checks passed
@taoteg taoteg deleted the task/WG-143 branch October 13, 2023 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sophia-massie sophia-massie sophia-massie approved these changes

@nathanfranklin nathanfranklin nathanfranklin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@taoteg @nathanfranklin @sophia-massie